Open
Conversation
Replaced CreateConfigurationFile with Settings.AddSource() and Settings.AddPackageSourceMapping() in 4 PMC source mapping tests to preserve SimpleTestPathContext defaults (globalPackagesFolder, etc.). Also reuse the default 'source' feed as the opensource repo where possible. Updated apex-migration skill with config gotcha learning. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
nkolev92
commented
Apr 21, 2026
Agent-Logs-Url: https://github.com/NuGet/NuGet.Client/sessions/69387abc-7df5-4ffa-ba29-f76c06e50ea5 Co-authored-by: nkolev92 <2878341+nkolev92@users.noreply.github.com>
Agent-Logs-Url: https://github.com/NuGet/NuGet.Client/sessions/69387abc-7df5-4ffa-ba29-f76c06e50ea5 Co-authored-by: nkolev92 <2878341+nkolev92@users.noreply.github.com>
nkolev92
commented
Apr 21, 2026
Agent-Logs-Url: https://github.com/NuGet/NuGet.Client/sessions/b7f564ae-9619-463a-9be9-20409e7b0ecf Co-authored-by: nkolev92 <2878341+nkolev92@users.noreply.github.com>
…pleTestPathContext - Migrate 2 PS PackageNameSpaceTests (restore with source mapping) to Apex - Fix 6 NuGetConsoleTestCase tests to use SimpleTestPathContext APIs instead of CreateConfigurationFile - Remove migrated PS functions and CreateCustomTestPackage helper Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…et/nuGet.Client into dev-nkolev92-migratePSMTests
The tests were writing packages.config manually via File.WriteAllText which the VS project system never detected. Now they install via PMC so the project system is aware, then delete both PackagesV2 and UserPackagesFolder to force restore to re-download from the mapped source during build. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#12185
Description
Migrates PowerShell E2E tests from
PackageNameSpaceTests.ps1to C# Apex tests. The feature was renamed from "PackageNameSpace" to "PackageSourceMapping", so new test names reflect the current terminology.PackageNameSpaceTests.ps1is now fully migrated — all test functions have been ported to Apex or deleted as duplicates.Migration decisions
Test-PackageSourceMappingRestore-WithSingleFeedNuGetConsoleTestCase.RestorePackageForPC_PackageSourceMapping_WithSingleFeedpackages.config, builds viaSolutionService.Build().Test-PackageSourceMappingRestore-WithMultipleFeedsWithIdenticalPackages-RestoresCorrectPackageNuGetConsoleTestCase.RestorePackageForPC_PackageSourceMapping_WithMultipleFeedsWithIdenticalPackages_RestoresCorrectPackageTest-VsPackageInstallerServices-PackageSourceMappingInstall-WithSingleFeed-SucceedIVsServicesTestCase.SimpleInstallFromIVsInstaller_PackageSourceMapping_WithSingleFeedTest-VsPackageInstallerServices-PackageSourceMappingInstall-WithSingleFeed-FailsIVsServicesTestCase.SimpleInstallFromIVsInstaller_PackageSourceMapping_WithMissingMappedSource_FailsTest-VsPackageInstallerServices-PackageSourceMappingInstall-WithMultipleFeedsWithIdenticalPackages-RestoresCorrectPackageWithSpecifiedVersionIVsServicesTestCase.SimpleInstallFromIVsInstaller_PackageSourceMapping_WithMultipleFeedsWithIdenticalPackages_InstallsCorrectPackageTest-VsPackageInstallerServices-PackageSourceMappingInstall-WithMultipleFeedsWithIdenticalPackages-RestoresCorrectPackageWithLatestVersionIVsServicesTestCase.SimpleInstallLatestFromIVsInstaller_PackageSourceMapping_WithMultipleFeedsWithIdenticalPackages_InstallsCorrectPackageTest-PC-PackageSourceMappingInstall-SucceedNuGetConsoleTestCase.InstallPackageForPC_PackageSourceMapping_WithSingleFeedTest-PC-PackageSourceMappingInstall-FailsNuGetConsoleTestCase.InstallPackageForPC_PackageSourceMapping_WithWrongMappedFeed_FailsTest-PC-PackageSourceMappingInstall-WithCorrectSourceOption-SucceedNuGetConsoleTestCase.InstallPackageForPC_PackageSourceMapping_WithCorrectSourceOption_InstallsCorrectPackage-Sourceto install from mapped private feed, verifies content file origin.Test-PC-PackageSourceMappingInstall-WithWrongSourceOption-FailsNuGetConsoleTestCase.InstallPackageForPC_PackageSourceMapping_WithWrongSourceOption_Fails-Sourcepoints to unmapped feed, asserts PMC error message.Test-PC-PackageSourceMappingUpdate-WithCorrectSourceOption-SucceedNuGetConsoleTestCase.UpdatePackageForPC_PackageSourceMapping_WithCorrectSourceOption_UpdatesCorrectPackageFile changes
NuGetConsoleTestCase.cs— 6 new PMC tests (tests 1, 2, 8, 9, 10, 11); addedSaveAll()after package operations to prevent save dialogIVsServicesTestCase.cs— 2 new IVs API tests (tests 4, 6); addedSaveAll()after package operationsVisualStudioHostExtension.cs— Fixed flakyClearErrorWindowby catchingOperationCanceledException(UI thread contention during best-effort cleanup)PackageNameSpaceTests.ps1— Fully migrated: all test functions removedSKILL.md— Updated Apex migration skill with learningsPR Checklist